Added Commandline Options #235

ghost · 2018-03-01T22:22:23Z

Added Commandline Options "--disable-hardware-acceleration" & "--force-devtools".

With this commit, hardware acceleration would be on as default. Linux User with problems can use the option "--disable-hardware-acceleration" forr the workaround mentioned in #128.

I also added the "--force-devtools" option, so you dont have to build a special version for debugging the production packages.

I think these should be documented in the readme, any suggestions where?

hql287 · 2018-03-02T05:10:34Z

@jens-t Thanks for the PR. 👍

Quick question: How do you know the exported app will take these argument (--force-devtools and --disable-hardware-acceleration)?

ghost · 2018-03-02T11:28:16Z

Quick question: How do you know the exported app will take these argument (--force-devtools and --disable-hardware-acceleration)?

I tested this with a special version, which logged some debug information to the devtools console. but you can test this in the following ways:

Dev-Server: electron . --force-devtools
Linux AppImage: ./Manta-1.1.2-x86_64.AppImage --force-devtools
Installed App (.deb): manta --force-devtools (works in the same way for macOS & win ...)
... and the devtools will start with the app.

hql287 · 2018-03-02T11:42:39Z

Ok, then I think we should update the README as well. Maybe somewhere in the Development section. Also, if we disable the Hardware Acceleration, will the black box show up again?

ghost · 2018-03-02T11:56:18Z

Ok, then I think we should update the README as well. Maybe somewhere in the Development section.

ok. but i think it doesn't fit in the development section. it's more a user feature, and maybe more flags are following, so it maybe deserves its own section. i make a suggestion with a commit.

Also, if we enable the Hardware Acceleration, will the black box show up again?

well, this pull request is referenced in the old pull request of the user having the problem. so the user should know, that there is a flag for this now. i searched the issues and found no one else having this problem, but i can add a short info to the readme ... linking to electron/electron#4322, but i think that is to niche and specific for the readme. other users that eventually will have the problem will also find the pull request of @c0b41. and it is a bug from februar 2016, so it is possible that the black box might not show at all, not even for @c0b41.

hql287 · 2018-03-02T13:24:01Z

@jens-t You're on Linux, right? Does the black box show up on your screen if you enable hardware acceleration?

ghost · 2018-03-02T13:37:38Z

Yes, thats right. And no, i dont have any problems with hwa on, but the app is broken for me with hwa off. The "black box problem" is an edge case, not a general problem for all linux users.

hql287 · 2018-03-05T01:35:56Z

README.md

@@ -104,6 +104,10 @@ Windows 7 and later are supported

 [More information](https://github.com/electron/electron/blob/master/docs/tutorial/supported-platforms.md).

+### App Start-Options


I think it would be better if we could add some kind of explanation for why it's here and what it does. Or better yet, reference the issue(s) that led to this change. I think Linux users will appreciate it. 👍

Also, it seems a little too short to has its own section, maybe move it under Development?

I think it would be better if we could add some kind of explanation for why it's here and what it does. Or better yet, reference the issue(s) that led to this change. I think Linux users will appreciate it.

Yes, thats a good idea. I make a proposal.

Also, it seems a little too short to has its own section, maybe move it under Development?

Is it really related to development? I also thought about adding a start option for a path to a custom theme, so maybe the section gets bigger in the future :) If it shouldn't be part of the readme, maybe it should get an own wiki page?

Yes, I think it's related to Development because you'll only use those options for development purpose. But I think it deserves its own Wiki page as well. Maybe we can title the page as "Debug in Production" or "Debug Exported App"?

I just updated the Wiki setting so everyone can contribute now, and I think the page should include this:

Dev-Server: electron . --force-devtools
Linux AppImage: ./Manta-1.1.2-x86_64.AppImage --force-devtools
Installed App (.deb): manta --force-devtools

Yes, the (1) "--force-devtools" option is really related to development & bug reporting, but (2) "--disable-hardware-acceleration" is a user setting for the app. So we should split the documentation of these two params to 2 different places. For (1) a "Debug Exported App" wiki page would fit. I would leave infos about (2) in the main readme.

I proposed this, cause i thought it's good to have all app start options documented in the same place. we can place all options in the wiki under the development section, but you wont find it there if you search for regular user app options.

I think it would be better if we could add some kind of explanation for why it's here and what it does.

I don't know what to explain. The title of the section and the paramname explain everything there is to explain, or?
Maybe: To give the user the possiblity to easily set some options for the app ...

I just added a short description to the README. Please have a look and let me know what you think. If it's ok then this PR is ready to be merged.

hql287 · 2018-03-06T03:40:45Z

Installed App (.deb): manta --force-devtools (works in the same way for macOS & win ...)

I just tested it out on my Mac but this didn't work.

open -a /Applications/Manta.app --force-devtools

Received this message instead:

open: unrecognized option `--force-devtools'

Dev-Server: electron . --force-devtools

Also, the devtools don't need to be forced to open in development mode, the conditional isDev would open them automatically.

ghost · 2018-03-06T09:39:57Z

I just tested it out on my Mac but this didn't work.

Mac has it's own non standard way, as always :) Try:

open -a /Applications/Manta.app --args --force-devtools

Also, the devtools don't need to be forced to open in development mode, the conditional isDev would open them automatically.

Yes and No. isDev detects the development env, forceDevtools is to open them in production mode. So forceDevtools has nothing to do with the development mode ...

But yeah, following example is misleading somehow:

Dev-Server: electron . --force-devtools

this command with the "--force-devtools" makes no sense, it was just an example how these params work in general.

Dev-Server: electron . --disable-hardware-acceleration

Would be a better example :)

hql287 · 2018-03-06T10:04:22Z

@jens-t Hm, I tried this and it opened the app but the devtools didn't show up.

open -a /Applications/Manta.app --args --force-devtools

ghost · 2018-03-06T11:08:48Z

Maybe you should take a look here:
https://superuser.com/questions/180995/passing-command-line-args-to-open-on-mac

the --args option exists since osx version 10.6 , maybe that's the problem?

hql287 · 2018-03-06T11:32:02Z

@jens-t Sorry my bad, I ran this command with the current version of Manta which didn't have the code presented in this PR 😆. Will export a new app and try again.

ghost · 2018-03-06T11:41:33Z

Tested with macOS 10.13.2
open -a /Applications/Manta.app --args --force-devtools
works! :)

ghost · 2018-03-06T16:38:46Z

Changed the readme, better?

hql287 · 2018-03-07T07:59:31Z

@jens-t: I just added a Wiki page for this. Please double check if I got the Linux commands right and also provide the command for Windows user if you have it.

ghost · 2018-03-07T11:00:15Z

I like that page! :) I test it on windows later and add that to the wiki page.

do i have to fork the wiki, or just clone and push to origin?

ghost · 2018-03-07T11:02:23Z

I also like your readme changes/additions!

hql287 · 2018-03-07T11:02:46Z

I think you can edit it directly. There should be an "Edit" button next to the green "New Page" button.

ghost · 2018-03-07T11:03:47Z

Ah yes, found it, thanks!

hql287 · 2018-03-07T11:04:34Z

I also like your readme changes/additions!

Okay, I'll go ahead and merge this first. Feel free to update that Wiki page whenever you have the time.

ghost · 2018-03-07T11:05:53Z

Will do!

ghost · 2018-03-07T13:31:35Z

Just for your information, no need to change anything:
Just found out, you don't have to use the open command on macOS, you can also type the path to the executable located in the program folder and use it the same way as in linux.

hql287 · 2018-03-07T15:21:31Z

Just found out, you don't have to use the open command on macOS, you can also type the path to the executable located in the program folder and use it the same way as in linux.

Not sure about this, because on my system, typing any path into the terminal would result in the cd command.

Update: Yup, I'm now in the /Application/Manta.app folder 😄

ghost · 2018-03-07T17:10:37Z

Read it somewhere, maybe the person used a custom shell. Good to know :)

jens-struct added 2 commits March 1, 2018 22:19

Merge branch 'dev-upstream' into dev

65e407a

add commandline options

b5684f8

added infos about app start-options

3296ab2

jens-struct added 2 commits March 2, 2018 15:53

Merge branch 'dev-upstream' into dev

263e568

Merge branch 'dev-upstream' into dev

d7de86b

hql287 added this to the Build 06 - v1.1.4 milestone Mar 2, 2018

hql287 assigned ghost Mar 3, 2018

Jens Tangermann and others added 4 commits March 4, 2018 00:41

Merge branch 'dev' into cmdline-flags

5e97730

Merge branch 'dev-upstream' into dev

e2a7c8b

Merge branch 'dev' into cmdline-flags

eb1f581

Merge branch 'dev' into cmdline-flags

015d3e5

hql287 reviewed Mar 5, 2018

View reviewed changes

Merge branch 'dev' into cmdline-flags

daf6091

hql287 added the enhancement label Mar 6, 2018

Merge branch 'dev' into cmdline-flags

c561b2b

changed readme

ac2898d

Merge branch 'dev-upstream' into dev

166bf10

Merge branch 'dev' into cmdline-flags

0aa3142

hql287 added 3 commits March 7, 2018 15:17

Add description for disable-hardware-acceleration flag

87818e3

Fixed typo

d526a36

Merge branch 'dev' into cmdline-flags

f409303

hql287 merged commit 929db27 into hql287:dev Mar 7, 2018

ghost deleted the cmdline-flags branch March 7, 2018 17:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Commandline Options #235

Added Commandline Options #235

ghost commented Mar 1, 2018

hql287 commented Mar 2, 2018

ghost commented Mar 2, 2018

hql287 commented Mar 2, 2018 •

edited

Loading

ghost commented Mar 2, 2018 •

edited by ghost

Loading

hql287 commented Mar 2, 2018

ghost commented Mar 2, 2018 •

edited by ghost

Loading

hql287 Mar 5, 2018 •

edited

Loading

ghost Mar 5, 2018 •

edited by ghost

Loading

hql287 Mar 6, 2018

ghost Mar 6, 2018 •

edited by ghost

Loading

ghost Mar 6, 2018

hql287 Mar 7, 2018

hql287 commented Mar 6, 2018 •

edited

Loading

ghost commented Mar 6, 2018 •

edited by ghost

Loading

hql287 commented Mar 6, 2018

ghost commented Mar 6, 2018

hql287 commented Mar 6, 2018

ghost commented Mar 6, 2018

ghost commented Mar 6, 2018

hql287 commented Mar 7, 2018

ghost commented Mar 7, 2018

ghost commented Mar 7, 2018

hql287 commented Mar 7, 2018

ghost commented Mar 7, 2018

hql287 commented Mar 7, 2018

ghost commented Mar 7, 2018

ghost commented Mar 7, 2018

hql287 commented Mar 7, 2018 •

edited

Loading

ghost commented Mar 7, 2018

		@@ -104,6 +104,10 @@ Windows 7 and later are supported

		[More information](https://github.com/electron/electron/blob/master/docs/tutorial/supported-platforms.md).

		### App Start-Options

Added Commandline Options #235

Added Commandline Options #235

Conversation

ghost commented Mar 1, 2018

hql287 commented Mar 2, 2018

ghost commented Mar 2, 2018

hql287 commented Mar 2, 2018 • edited Loading

ghost commented Mar 2, 2018 • edited by ghost Loading

hql287 commented Mar 2, 2018

ghost commented Mar 2, 2018 • edited by ghost Loading

hql287 Mar 5, 2018 • edited Loading

Choose a reason for hiding this comment

ghost Mar 5, 2018 • edited by ghost Loading

Choose a reason for hiding this comment

hql287 Mar 6, 2018

Choose a reason for hiding this comment

ghost Mar 6, 2018 • edited by ghost Loading

Choose a reason for hiding this comment

ghost Mar 6, 2018

Choose a reason for hiding this comment

hql287 Mar 7, 2018

Choose a reason for hiding this comment

hql287 commented Mar 6, 2018 • edited Loading

ghost commented Mar 6, 2018 • edited by ghost Loading

hql287 commented Mar 6, 2018

ghost commented Mar 6, 2018

hql287 commented Mar 6, 2018

ghost commented Mar 6, 2018

ghost commented Mar 6, 2018

hql287 commented Mar 7, 2018

ghost commented Mar 7, 2018

ghost commented Mar 7, 2018

hql287 commented Mar 7, 2018

ghost commented Mar 7, 2018

hql287 commented Mar 7, 2018

ghost commented Mar 7, 2018

ghost commented Mar 7, 2018

hql287 commented Mar 7, 2018 • edited Loading

ghost commented Mar 7, 2018

hql287 commented Mar 2, 2018 •

edited

Loading

ghost commented Mar 2, 2018 •

edited by ghost

Loading

ghost commented Mar 2, 2018 •

edited by ghost

Loading

hql287 Mar 5, 2018 •

edited

Loading

ghost Mar 5, 2018 •

edited by ghost

Loading

ghost Mar 6, 2018 •

edited by ghost

Loading

hql287 commented Mar 6, 2018 •

edited

Loading

ghost commented Mar 6, 2018 •

edited by ghost

Loading

hql287 commented Mar 7, 2018 •

edited

Loading